Wire Telemetry metric views config to Beholder and LOOP plugins#23085
Draft
pkcll wants to merge 3 commits into
Draft
Wire Telemetry metric views config to Beholder and LOOP plugins#23085pkcll wants to merge 3 commits into
pkcll wants to merge 3 commits into
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
|
|
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
af4fd5e to
a43c1b3
Compare
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
2 times, most recently
from
6098e68 to
b5f8fd9
Compare
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
331b2f2 to
724abfc
Compare
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
2 times, most recently
from
5f369f9 to
1a9e28e
Compare
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
107f0e8 to
3bbc6a1
Compare
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
1a9e28e to
ddcec5d
Compare
pkcll
changed the base branch from
beholder-otel-limit-metric-cardinality
to
develop
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
ddcec5d to
fae259e
Compare
Add MetricViewsDisabled and MetricViewsAttributeBlacklist to core.toml, forward through shell and loop registry, and bump chainlink-common to ff6c540906a9 for companion PR chainlink-common #2238. Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
fae259e to
8768af3
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
0e14f8c to
bbb94f0
Compare
|
Drop MetricViewsDisabled; empty MetricViewsAttributeDenylist disables default views. Rename blacklist to denylist and bump chainlink-common to c2bb0f6d4. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to chainlink-common #2238. Bases on
develop(independent of chainlink #23084).MetricViewsDisabledandMetricViewsAttributeBlacklistunder[Telemetry]incore.toml(defaults:false,["event_id"])shell.goBeholder client, and LOOP plugin env forwardingdocs/CONFIG.mdand update config golden fixtures (web resolver + txtar validate scripts)chainlink-commontov0.11.2-0.20260713174720-ff6c540906a9(ff6c540906a9, common Bump go.dedis.ch/kyber/v3 from 3.0.11 to 3.0.12 #2238 head)Test plan
go test ./core/services/chainlink/... ./plugins/...main(Validate go.mod dependencies)event_idis dropped from exported metrics with default configMerge order
mainmaindevelop